Remove support for h5py older than 3.9#18492
Merged
pllim merged 1 commit intoastropy:mainfrom Aug 7, 2025
Merged
Conversation
Older versions of `h5py` used `numpy.product()`, which was deprecated in `numpy` 1.25. Not supporting old `h5py` prevents deprecation warnings with most supported `numpy` versions.
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
This is in the realm of |
matteobachetti
approved these changes
Aug 7, 2025
Contributor
|
I think we have done far more breaking changes in the past ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
numpy.product()was deprecated innumpy1.25 buth5pyversions older than 3.9 were still using it. Dropping support for olderh5pyversions prevents problems with our oldest dependencies CI job when we get to dropping support fornumpy1.24. In principle it will also prevent users who will have installed latestastropy, not the oldest supportednumpyand the oldest supportedh5pyfrom seeing deprecation warnings they can't do anything about, but in practice I suspect the number of users who have such a set of packages installed is not large.h5py3.9 was released in June 2023, so SPEC 0 allows us to move ahead with this.