Skip to content

Backport PR #18191 on branch v7.1.x (Import standard library types at runtime)#18225

Merged
pllim merged 1 commit intoastropy:v7.1.xfrom
eerovaher:backport-runtime-std-imports
Jun 6, 2025
Merged

Backport PR #18191 on branch v7.1.x (Import standard library types at runtime)#18225
pllim merged 1 commit intoastropy:v7.1.xfrom
eerovaher:backport-runtime-std-imports

Conversation

@eerovaher
Copy link
Member

Description

This is a manual backport of #18191. Apparently #18191 would be enough to solve the documentation build problems specutils have with astropy 7.1.0, but that pull request was merged to main. It would be best to try building the specutils documentation with this pull request too just to make sure that nothing went wrong with the manual backporting.

Closes #18221

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-project-automation github-project-automation bot moved this from Triage to Reviewer approved in Cosmology, the Expansion Jun 5, 2025
@pllim pllim merged commit 3552fc3 into astropy:v7.1.x Jun 6, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Cosmology, the Expansion Jun 6, 2025
@pllim
Copy link
Member

pllim commented Jun 6, 2025

Thanks, all!

@eerovaher eerovaher deleted the backport-runtime-std-imports branch June 6, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Downstream docs build failing due to 7.1.0 release

4 participants