Skip to content

Drop support for matplotlib < 3.8#18164

Merged
pllim merged 1 commit intoastropy:mainfrom
eerovaher:matplotlib380
May 22, 2025
Merged

Drop support for matplotlib < 3.8#18164
pllim merged 1 commit intoastropy:mainfrom
eerovaher:matplotlib380

Conversation

@eerovaher
Copy link
Copy Markdown
Member

@eerovaher eerovaher commented May 20, 2025

Description

SPEC 0 allows us to drop support for matplotlib < 3.8. Doing so lets us remove some compatibility code. Furthermore, this will simplify updating our numpy requirement, which will allow us to remove even more compatibility code.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@eerovaher eerovaher added this to the v7.2.0 milestone May 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

eerovaher
eerovaher commented May 20, 2025
View reviewed changes
astropy/tests/figures/py311-test-image-mploldest-cov.json
"astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_axisbelow[False]": "ee1e46856a19ba472ae9ea4588c614fbbd1b3a4a0787ef40e33f991a8f79d6c0",
"astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_axisbelow[line]": "516c3882bbaa31a0d241eec2c70aca45b27b44929662371718b10025735db772",
"astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_contour_overlay": "44fd1a202f8baa894a289bac150b3b0eda9b069a06fc8f49ce14d77e743481e0",
"astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_contour_overlay": "8679305e8a8b5b3f5b896343f4e16dfc65e9289c31505e3b35ef773d7837c8ea",
Copy link
Copy Markdown
Member Author

@eerovaher eerovaher May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated hash is the same as the one in the other file, so it must be fine

astropy/astropy/tests/figures/py311-test-image-mpldev-cov.json

Line 12 in 16a94b4

"astropy.visualization.wcsaxes.tests.test_images.TestBasic.test_contour_overlay": "8679305e8a8b5b3f5b896343f4e16dfc65e9289c31505e3b35ef773d7837c8ea",

mhvk
mhvk approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good (certainly for utils.masked -- I looked at the rest too, but may some of the others want to have a look at those changes).

@pllim pllim requested a review from Cadair May 20, 2025 21:31
@pllim
Copy link
Copy Markdown
Member

pllim commented May 20, 2025

Thanks. LGTM but I'll give visualization maintainers a chance to review.

@astrofrog
Copy link
Copy Markdown
Member

astrofrog commented May 21, 2025

Looks ok to me in general but I think we should not change to use mploldest in the test env name because the env names are used here:

https://github.com/astropy/astropy-figure-tests

And if we use a name like mploldest, different astropy versions might have different understandings of what oldest is (it works for dev because dev is always dev)

@pllim
Copy link
Copy Markdown
Member

pllim commented May 21, 2025

Hmm having to update the test data repo to accommodate this PR would be out of scope. Can we please revert the "oldest" changes? Thanks, all.

pllim
pllim approved these changes May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pllim pllim merged commit 9f5af76 into astropy:main May 22, 2025
27 checks passed
@pllim
Copy link
Copy Markdown
Member

pllim commented May 22, 2025

I updated main branch protection rules with the new job name added here. Please let me know if anything is amiss. Thanks, all!

@eerovaher eerovaher deleted the matplotlib380 branch May 22, 2025 16:56
@pllim pllim mentioned this pull request May 22, 2025
Merged
1 task
@eerovaher eerovaher mentioned this pull request May 26, 2025
Merged
1 task
This was referenced Nov 18, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

@mhvk mhvk mhvk approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog astrofrog is a code owner

@larrybradley larrybradley Awaiting requested review from larrybradley larrybradley is a code owner

@Cadair Cadair Awaiting requested review from Cadair

Assignees

No one assigned

Labels

Docs installation testing utils.masked visualization.wcsaxes

Projects

None yet

Milestone

v7.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eerovaher @pllim @astrofrog @mhvk