-
-
Notifications
You must be signed in to change notification settings - Fork 2k
MNT: upgrade codespell (v2.3.0 -> v2.4.1)
#17720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
v2.3.0 -> v2.4.1)
|
I don't see the point of this tool renaming a variable |
There's not point, it's purely a side effect from Since @eerovaher opened #17725 with an even more opinionated approach, I'm going to revamp this one to simply ignore this one word so hopefully one of these PRs can be merged quickly. |
78a0e56 to
3f21a4a
Compare
| >>> cli = SAMPIntegratedClient() | ||
| >>> ... | ||
| >>> cli.ereply("abd", SAMP_STATUS_ERROR, result={}, | ||
| >>> cli.ereply("message_id", SAMP_STATUS_ERROR, result={}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taken from #17725
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much less controversial now. Thanks!
Description
This is a semi manual upgrade (originally automated in #17710).
All changes are automatic, except for a couple
# codespell:ignorecomments that I added manually.The update is a bit noisy because of
indxvariables being re-namedindex, though I checked that it only happened in private scopes so it shouldn't have any user-visible effect.