Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

Description

This is a semi manual upgrade (originally automated in #17710).
All changes are automatic, except for a couple # codespell:ignore comments that I added manually.
The update is a bit noisy because of indx variables being re-named index, though I checked that it only happened in private scopes so it shouldn't have any user-visible effect.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title MNT: upgrade codespell (v2.3.0 -> v2.4.1) MNT: upgrade codespell (v2.3.0 -> v2.4.1) Feb 4, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review February 4, 2025 11:13
@pllim pllim removed the skip-changelog-checks Tells bot to skip changlog checks label Feb 4, 2025
@pllim
Copy link
Member

pllim commented Feb 4, 2025

I don't see the point of this tool renaming a variable indx to index. Can we not do that? Thanks!

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Feb 6, 2025

I don't see the point of this tool renaming a variable indx to index. Can we not do that? Thanks!

There's not point, it's purely a side effect from codespell not knowing the difference between a variable name and regular text. My opinion is that accepting fixes as they come up via upgrades creates less friction than discussing wether we should ignore them or not overall, though it's immediately invalidated if it's not consensual.

Since @eerovaher opened #17725 with an even more opinionated approach, I'm going to revamp this one to simply ignore this one word so hopefully one of these PRs can be merged quickly.

@neutrinoceros neutrinoceros force-pushed the mnt/upgrade_codespell_2.4.1 branch from 78a0e56 to 3f21a4a Compare February 6, 2025 08:57
>>> cli = SAMPIntegratedClient()
>>> ...
>>> cli.ereply("abd", SAMP_STATUS_ERROR, result={},
>>> cli.ereply("message_id", SAMP_STATUS_ERROR, result={},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from #17725

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much less controversial now. Thanks!

@pllim pllim merged commit 96dc3d6 into astropy:main Feb 6, 2025
27 checks passed
@neutrinoceros neutrinoceros deleted the mnt/upgrade_codespell_2.4.1 branch February 6, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants