Skip to content

TST: require pytest 8.0 or newer#17675

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/dep/require_pytest_8
Jan 27, 2025
Merged

TST: require pytest 8.0 or newer#17675
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/dep/require_pytest_8

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

Happy birthday pytest 8.0 !
Close #15180

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros force-pushed the tst/dep/require_pytest_8 branch from 55e578d to f31ef43 Compare January 27, 2025 08:13
@neutrinoceros neutrinoceros added the Extra CI Run cron CI as part of PR label Jan 27, 2025
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Failures on ppc64le and s390x are unrelated, see #17663 and #17664

@neutrinoceros neutrinoceros marked this pull request as ready for review January 27, 2025 08:52
Copy link
Copy Markdown
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I looked through everything and it looks good (was a bit confused by two CacheMissingWarning in utils/tests/test_data.py, but it seems two warnings are actually raised).

@pllim pllim merged commit f1b0809 into astropy:main Jan 27, 2025
@pllim
Copy link
Copy Markdown
Member

pllim commented Jan 27, 2025

Thanks for the clean-up!

p.s. Did you have pytest release date marked on your calendar? 😆

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Did you have pytest release date marked on your calendar?

Guilty as charged 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TST: Pin to pytest>=8 when we can

4 participants