TST: update cooodinates accuracy test data#16980
TST: update cooodinates accuracy test data#16980neutrinoceros wants to merge 2 commits intoastropy:mainfrom
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
I didn't go over all the values, but from the quick glance I took I got the impression that the numbers aren't different at all, the updated script just writes out more digits. If it is indeed the case that limiting the number of digits in the output replicates the data as it is then the only changes would be in the file headers, and those are small enough that we can easily handle them in #16976 and this pull request wouldn't be needed. |
|
Does the unified IO interface allows to set the output precision somehow ? |
|
If you can get the diff smaller with the precision thingy, that would be nice. My two cents, FWIW. Thanks, all! |
9cbc353 to
470d198
Compare
|
Thanks ! I think I got the diff smaller by forcing outputs to 10 digits. I updated both PRs. |
|
It looks to me like the original format is 12 digits in total (meaning 9-11 digits to the right of the decimal point depending on how many digits there are to the left of it), but without trailing zeros. If there is a way to force the new data to be like that then it should be possible to make the diff much smaller. |
|
I don't know how to achieve what you're suggesting. I also suspect that it might also have to do with Python 2 VS 3. |
| ) | ||
| t.write(f, format="ascii", delimiter=",") | ||
| formats = { | ||
| k: "%0.10f" for k in "ra_in,dec_in,ra_fk5,dec_fk5,ra_fk4,dec_fk4".split(",") |
There was a problem hiding this comment.
| k: "%0.10f" for k in "ra_in,dec_in,ra_fk5,dec_fk5,ra_fk4,dec_fk4".split(",") | |
| k: ".12g" for k in "ra_in,dec_in,ra_fk5,dec_fk5,ra_fk4,dec_fk4".split(",") |
There was a problem hiding this comment.
that's it ! thanks a LOT. There's no difference after that, so I'll close this PR and include your suggestion in #16976
Description
This is a continuation of #16976 with the addition of a commit that updates test data following a run of the
generate_ref_ast.pyscript.Let's see how this does in CI.