Skip to content

Revert "Improve fitting performance of most non-linear fitters"#16979

Closed
pllim wants to merge 1 commit intomainfrom
revert-16673-improve-modeling-performance
Closed

Revert "Improve fitting performance of most non-linear fitters"#16979
pllim wants to merge 1 commit intomainfrom
revert-16673-improve-modeling-performance

Conversation

@pllim
Copy link
Member

@pllim pllim commented Sep 10, 2024

Reverts #16673

because @mcara reported unintentional API breakage downstream.

@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release skip-changelog-checks Tells bot to skip changlog checks labels Sep 10, 2024
@pllim pllim added this to the v7.0.0 milestone Sep 10, 2024
@pllim pllim requested review from Cadair, astrofrog and mcara September 10, 2024 02:06
@pllim pllim requested a review from a team as a code owner September 10, 2024 02:06
@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@astrofrog
Copy link
Member

Please wait until we can investigate an alternative fix in the next couple of days.

@mcara
Copy link
Contributor

mcara commented Sep 10, 2024

I fixed the breakage in my package so this is not an emergency, not at all. I just wanted to draw attention to this.

@pllim
Copy link
Member Author

pllim commented Sep 10, 2024

Superseded by #16982

@pllim pllim closed this Sep 10, 2024
@pllim pllim deleted the revert-16673-improve-modeling-performance branch September 10, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release modeling skip-changelog-checks Tells bot to skip changlog checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants