Skip to content

MNT: Run PTH flake test in prep for supporting pathlib (io.registry)#16956

Draft
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:io.registry/rfc/pth_checks
Draft

MNT: Run PTH flake test in prep for supporting pathlib (io.registry)#16956
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:io.registry/rfc/pth_checks

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Sep 6, 2024

Description

Ref #16924
This is in the continuation of #16060

Based off, and blocked by #16955
From local testing, it looks like I'll also need to tackle io.votable before I can undraft this one.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title MNT: Run PTH flake test in prep for supporting pathlib (io.registry) MNT: Run PTH flake test in prep for supporting pathlib (io.registry) (⏰ wait for #16955) Sep 6, 2024
@pllim pllim added this to the v7.0.0 milestone Sep 6, 2024
@pllim pllim added no-changelog-entry-needed Extra CI Run cron CI as part of PR labels Sep 6, 2024
@neutrinoceros neutrinoceros modified the milestones: v7.0.0, v7.1.0 Oct 16, 2024
@neutrinoceros neutrinoceros changed the title MNT: Run PTH flake test in prep for supporting pathlib (io.registry) (⏰ wait for #16955) MNT: Run PTH flake test in prep for supporting pathlib (io.registry) Oct 16, 2024
@neutrinoceros neutrinoceros force-pushed the io.registry/rfc/pth_checks branch from c50ff89 to b396ef7 Compare October 16, 2024 17:16
@github-actions github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Mar 16, 2025
@github-actions
Copy link
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@neutrinoceros neutrinoceros added keep-open and removed Close? Tell stale bot that this issue/PR is stale labels Mar 17, 2025
@astrofrog astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025
@astrofrog astrofrog modified the milestones: v7.2.0, v8.0.0 Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants