MNT: Run PTH flake test in prep for supporting pathlib (wcs) by neutrinoceros · Pull Request #16936 · astropy/astropy

neutrinoceros · 2024-09-04T09:25:04Z

Description

Extracted from #16060. Ref #16924

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2024-09-04T09:25:29Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2024-09-04T09:25:32Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

pyproject.toml

astropy/wcs/setup_package.py

astropy/wcs/__init__.py

neutrinoceros · 2024-10-16T08:11:33Z

If I understand correctly this is waiting on a new extension-helpers release (@astrofrog), but it also look like the PR could go in without it.
@nstarman what do you think ?

astrofrog · 2024-10-16T13:58:09Z

@neutrinoceros - FYI I've just triggered a 1.2.0 release of extension-helpers: https://github.com/astropy/extension-helpers/releases/tag/v1.2.0 - build ongoing

neutrinoceros · 2024-10-16T14:34:20Z

Thanks @astrofrog ! I took advantage of it to simplify this PR

neutrinoceros · 2024-10-16T16:46:40Z

whoops, I neglected that we cannot trivially bump build time dependencies without breaking exotic archs, so let me postpone this last commit to a follow up PR.

update: this is #17193

neutrinoceros · 2024-10-25T13:24:01Z

We're hours away from astropy 7.0's feature freeze and this shouldn't be blocking in any way, so I'll bump the milestone to clear the backlog. If this happened to be merged today anyway, please revert the milestone.

github-actions · 2025-03-16T05:39:16Z

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

astropy/wcs/__init__.py

astropy/wcs/wcs.py

nstarman · 2025-03-16T14:01:16Z

astropy/wcs/tests/test_wcs.py

 def test_tpv_ctype_tan():
    sip_header = fits.Header.fromstring(
-        get_pkg_data_contents(os.path.join("data", "siponly.hdr"), encoding="binary")
+        get_pkg_data_contents(Path("data") / "siponly.hdr", encoding="binary")


maybe consolidate the Path("data") here and below into a variable?
Actually, make it a pytest fixture! It's used all over this file.

Actually! put it in wcs/tests/conftest.py then it can be used across all the wcs/tests.

Hum, I'm not convinced that such a small fixture is worth adding an indirection to all tests that would use it.

astropy/wcs/setup_package.py

Co-authored-by: Mridul Seth <git@mriduls.com>

neutrinoceros · 2025-03-16T18:33:23Z

@nstarman thank you for picking this up. I should have addressed all your points.

nstarman · 2025-03-16T21:04:57Z

@neutrinoceros more test coverage needed?

neutrinoceros · 2025-03-17T08:18:51Z

done

nstarman

Given the followup to un-stringify some of these paths, LGTM! Thanks @neutrinoceros.
Whom else needs to approve?

pllim · 2025-03-17T14:11:17Z

astropy/wcs/wcsapi/low_level_api.py

Hmm low level API is bound by https://github.com/astropy/astropy-APEs/blob/main/APE14.rst . Does GWCS need to buy in also? cc @astrofrog @Cadair @nden

pllim · 2025-06-18T15:00:41Z

Given the recent revert of PTH changes, let's not do this for now. Thanks anyway!

github-actions bot added testing wcs wcs.wcsapi dev-automation labels Sep 4, 2024

neutrinoceros mentioned this pull request Sep 4, 2024

MNT: Run PTH flake test in prep for supporting pathlib #16924

Closed

neutrinoceros force-pushed the wcs/rfc/pth_checks branch from 889e399 to ea7c99d Compare September 4, 2024 09:58

neutrinoceros commented Sep 4, 2024

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

neutrinoceros marked this pull request as ready for review September 4, 2024 10:11

neutrinoceros requested review from WilliamJamieson, astrofrog, mcara and nstarman as code owners September 4, 2024 10:11

pllim added this to the v7.0.0 milestone Sep 4, 2024

pllim added the Extra CI Run cron CI as part of PR label Sep 4, 2024

neutrinoceros force-pushed the wcs/rfc/pth_checks branch from ea7c99d to b61e873 Compare September 4, 2024 17:48

nstarman reviewed Sep 4, 2024

View reviewed changes

astropy/wcs/setup_package.py Show resolved Hide resolved

astropy/wcs/__init__.py Show resolved Hide resolved

neutrinoceros force-pushed the wcs/rfc/pth_checks branch 2 times, most recently from 5ff91c3 to 667e602 Compare September 5, 2024 11:22

neutrinoceros marked this pull request as draft September 5, 2024 11:28

astrofrog removed their request for review September 5, 2024 14:09

neutrinoceros force-pushed the wcs/rfc/pth_checks branch from 667e602 to afdf630 Compare September 10, 2024 18:20

neutrinoceros marked this pull request as ready for review September 10, 2024 18:21

neutrinoceros force-pushed the wcs/rfc/pth_checks branch 2 times, most recently from 470e71b to 8579ab1 Compare October 16, 2024 08:21

neutrinoceros marked this pull request as draft October 16, 2024 14:27

neutrinoceros marked this pull request as ready for review October 16, 2024 14:34

neutrinoceros force-pushed the wcs/rfc/pth_checks branch 2 times, most recently from 8579ab1 to 15d5ac8 Compare October 16, 2024 16:48

neutrinoceros mentioned this pull request Oct 16, 2024

BLD: require extension-helpers 1.2.0 and simplify path type casting (⏰ wait for #16936) #17193

Draft

1 task

neutrinoceros modified the milestones: v7.0.0, v7.1.0 Oct 25, 2024

github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Mar 16, 2025

nstarman reviewed Mar 16, 2025

View reviewed changes

neutrinoceros force-pushed the wcs/rfc/pth_checks branch from 15d5ac8 to d2f5173 Compare March 16, 2025 14:58

MNT: Run PTH flake test in prep for supporting pathlib (wcs)

a58249e

Co-authored-by: Mridul Seth <git@mriduls.com>

neutrinoceros force-pushed the wcs/rfc/pth_checks branch from 0d4917f to a58249e Compare March 16, 2025 17:38

TST: add test coverage for astropy.wcs.get_include

bab62b2

nstarman approved these changes Mar 17, 2025

View reviewed changes

pllim reviewed Mar 17, 2025

View reviewed changes

astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025

pllim closed this Jun 18, 2025

neutrinoceros deleted the wcs/rfc/pth_checks branch June 18, 2025 15:25

Uh oh!

Conversation

neutrinoceros commented Sep 4, 2024

Description

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neutrinoceros commented Oct 16, 2024

Uh oh!

astrofrog commented Oct 16, 2024

Uh oh!

neutrinoceros commented Oct 16, 2024

Uh oh!

neutrinoceros commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neutrinoceros commented Oct 25, 2024

Uh oh!

github-actions bot commented Mar 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nstarman Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

nstarman Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

nstarman Mar 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

neutrinoceros commented Mar 16, 2025

Uh oh!

nstarman commented Mar 16, 2025

Uh oh!

neutrinoceros commented Mar 17, 2025

Uh oh!

nstarman left a comment

Choose a reason for hiding this comment

Uh oh!

pllim Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

pllim commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neutrinoceros commented Oct 16, 2024 •

edited

Loading