MNT: Run PTH flake test in prep for supporting pathlib (visualization)#16935
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
There was a problem hiding this comment.
Not sure what this script is for, so I'll let subpackage maintainer decide if supporting Path here needs a change log or not. Thanks!
There was a problem hiding this comment.
I think we should probably just have a single changelog entry in 'other' which mentions that a number of functions now support Path, rather than fully enumerating all the functions that now support it.
astrofrog
left a comment
There was a problem hiding this comment.
Looks good to me though note the failure due to the missing changelog. I don't mind if we include one changelog entry per PR or if we mark them all as not needing one then add a single changelog entry later that says that many/all functions in astropy that accept filenames now accept paths.
|
Actually maybe worth just adding a changelog entry, it might not be that many functions in the end. Certainly it's not for this sub-package. |
|
I'm confused: I didn't think the affected function was meant to be public ? I do see a |
Co-authored-by: Mridul Seth <git@mriduls.com>
9f839cb to
edf9b9f
Compare
|
Yeah I don't think we ship the scripts as "public API"? Merging. Thanks! |
Description
Extracted from #16060. Ref #16924