MNT: Run PTH flake test in prep for supporting pathlib (coordinates) by neutrinoceros · Pull Request #16932 · astropy/astropy

neutrinoceros · 2024-09-04T09:13:14Z

Description

Extracted from #16060. Ref #16924

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2024-09-04T09:13:38Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions · 2024-09-04T09:13:41Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

astropy/coordinates/name_resolve.py

eerovaher · 2024-09-04T15:47:17Z

astropy/coordinates/tests/accuracy/generate_ref_ast.py

I tried running this script to ensure the updates don't cause any changes in the data files it produces, but I was unable to install starlink-pyast. That package has not been updated for years, so it might not be possible to run this script with current versions of our dependencies at all. This script was used for generating some data files for tests, so it requiring some specific (and old) set of dependencies to run could be acceptable, but we should first find out what that set of dependencies is and avoid making any changes to this file until we know how to run it.

I could figure out how to install starlink-pyast and added PEP 723 metadata to the script for the next reader.
At the moment it seems that the script is indeed broken, but not by my patch: it's already broken on main. Before I dig any further, do you think it's worth fixing or should we instead remove this (clearly ?) unused script ?

The purpose of this script is to allow replicating some of our test data. Not being able to run it is a real problem. If we can't get this script to work then we might have to replace the data that it generated.

Getting the script to work with current astropy dependencies would be the best outcome, but if some older versions are required then that can be acceptable, as long as they are adequately documented.

I see, thanks for clarifying this. I'll spend some more time trying to fix this script or find a way to make it work with an older version if I have to.

Here's the PR for this script #16976

eerovaher · 2024-09-04T15:52:39Z

astropy/coordinates/tests/accuracy/generate_spectralcoord_ref.py

Have you verified that this script still works as intended?

I actually didn't realize it was a script and might not be tested. I'll give it a try.

Also could not run this on main: check_output(["rv", "rv.input"]) is failing with

FileNotFoundError: [Errno 2] No such file or directory: 'rv'

From the comment it seems that rv is supposed to be an entry point in Starlink, but I don't know where to install that from.

There is a comment at the top of the file with instructions, but I haven't tried following them.

Unfortunately these instructions do not explain where the rv command is to be found. It just says that it's needed. It looks like it was added in #10185 so let's ask @astrofrog about it.

Still waiting on @astrofrog's reply here. In the meantime, let's bump the milestone on this one.

Ping @astrofrog :)

astropy/coordinates/transformations/graph.py

astropy/coordinates/name_resolve.py

nstarman · 2024-09-11T17:29:11Z

astropy/coordinates/tests/accuracy/generate_spectralcoord_ref.py

-                f" {row['obslat'].to_string('deg', sep=' ')}\n"
+        rv_input = Path("rv.input")
+        rv_input.write_text(
+            "".join(


do these need a join?
String joining happens automatically if the strings are on consecutive lines.

thanks. Indeed there was room for simplification here

github-actions · 2025-02-09T05:39:44Z

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

Co-authored-by: Mridul Seth <git@mriduls.com>

github-actions · 2025-07-13T05:41:19Z

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

github-actions · 2025-08-13T05:40:49Z

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

github-actions bot added testing coordinates dev-automation labels Sep 4, 2024

neutrinoceros mentioned this pull request Sep 4, 2024

MNT: Run PTH flake test in prep for supporting pathlib #16924

Closed

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch 2 times, most recently from 23013d1 to 9541f7d Compare September 4, 2024 09:46

neutrinoceros marked this pull request as ready for review September 4, 2024 10:01

neutrinoceros requested review from WilliamJamieson and nstarman as code owners September 4, 2024 10:01

eerovaher requested changes Sep 4, 2024

View reviewed changes

eerovaher added Refactoring no-changelog-entry-needed labels Sep 4, 2024

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch from 3fc29e5 to aaddb6d Compare September 4, 2024 16:42

neutrinoceros marked this pull request as draft September 4, 2024 16:55

pllim added this to the v7.0.0 milestone Sep 4, 2024

pllim reviewed Sep 4, 2024

View reviewed changes

astropy/coordinates/name_resolve.py Show resolved Hide resolved

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch from 8a11a6d to 622cfd5 Compare September 9, 2024 09:07

neutrinoceros mentioned this pull request Sep 9, 2024

BUG: fix generate_ref_ast.py helper script and add installation instructions for it #16976

Merged

1 task

neutrinoceros changed the title ~~MNT: Run PTH flake test in prep for supporting pathlib (coordinates)~~ MNT: Run PTH flake test in prep for supporting pathlib (coordinates) (⏰ wait for #16976) Sep 10, 2024

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch from 622cfd5 to 16007f0 Compare September 11, 2024 14:21

neutrinoceros changed the title ~~MNT: Run PTH flake test in prep for supporting pathlib (coordinates) (⏰ wait for #16976)~~ MNT: Run PTH flake test in prep for supporting pathlib (coordinates) Sep 11, 2024

neutrinoceros marked this pull request as ready for review September 11, 2024 14:56

nstarman reviewed Sep 11, 2024

View reviewed changes

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch 2 times, most recently from 2eedd45 to 7f535c8 Compare September 11, 2024 19:03

neutrinoceros modified the milestones: v7.0.0, v7.1.0 Oct 16, 2024

github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Feb 9, 2025

MNT: Run PTH flake test in prep for supporting pathlib (coordinates)

caece78

Co-authored-by: Mridul Seth <git@mriduls.com>

neutrinoceros force-pushed the coordinates/rfc/pth_checks branch from 7f535c8 to caece78 Compare February 12, 2025 12:25

neutrinoceros removed the Close? Tell stale bot that this issue/PR is stale label Feb 12, 2025

astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025

github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Jul 13, 2025

github-actions bot added the closed-by-bot Closed by stale bot label Aug 13, 2025

github-actions bot closed this Aug 13, 2025

neutrinoceros deleted the coordinates/rfc/pth_checks branch August 13, 2025 05:51

Uh oh!

Conversation

neutrinoceros commented Sep 4, 2024

Description

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 9, 2025

Uh oh!

github-actions bot commented Jul 13, 2025

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants