ENH/BUG: improve support for pathlib.Path inputs in iers#16931
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
9aea4d1 to
86be650
Compare
IERS_A/B from pathlib.Path objects
|
This might naturally fix #16929 also but you should confirm. |
mhvk
left a comment
There was a problem hiding this comment.
This looks good, thanks! I do think we should have at least one test - fine to adjust one of the existing ones to pass in a path instead of a string.
just checked, and it doesn't. |
|
... but now it does ! The fix is actually orthogonal to the initial goal of this PR but it indeed felt related enough to be bundled with it. Let me know if you'd like me to split the PR instead. |
IERS_A/B from pathlib.Path objectspathlib.Path inputs in iers
6aa2f29 to
6e3c04a
Compare
done ! I parametrized the only existing test using |
6e3c04a to
c1941ad
Compare
astrofrog
left a comment
There was a problem hiding this comment.
This seems ok to me - thanks!
mhvk
left a comment
There was a problem hiding this comment.
Super, great that you could fix the leap seconds too!
Description
Ref: #14893
fixes #16929
This relieves a specific pain point I encountered while working on #16928, and participates to unblock it.
TODO: