ENH: improve support for Path objects in io.ascii.core.BaseInputter.get_lines#16930
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
4722435 to
c5a7dcb
Compare
Path objects in io.ascii.core.BaseInputter.get_lines
c5a7dcb to
1fe8042
Compare
|
RTD is failing... presumably unrelated but I don't have the power to get around that. |
|
whoops. It is actually related Let me try and fix the changelog fragment. |
e70b6fd to
e5fbfe7
Compare
|
CI green now. @taldcroft do you want to re-review? |
e5fbfe7 to
2cffa24
Compare
|
@taldcroft or feel free to move this to 7.1 |
|
We're hours away from astropy 7.0's feature freeze and this shouldn't be blocking in any way, so I'll bump the milestone to clear the backlog. If this happened to be merged today anyway, please revert the milestone. |
dhomeier
left a comment
There was a problem hiding this comment.
See note, otherwise this seems a useful improvement.
96bab41 to
bacd246
Compare
dhomeier
left a comment
There was a problem hiding this comment.
Thanks; on my part this would be good to go for 7.0, but I think @taldcroft should have a final look for that.
Description
Ref: #14893
This relieves a specific pain point I encountered while working on #16928, and participates to unblock it.
TODO: