MNT: Run PTH flake test in prep for supporting pathlib (astropy.logger)#16926
Merged
pllim merged 1 commit intoastropy:mainfrom Sep 3, 2024
Merged
MNT: Run PTH flake test in prep for supporting pathlib (astropy.logger)#16926pllim merged 1 commit intoastropy:mainfrom
pllim merged 1 commit intoastropy:mainfrom
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Co-authored-by: Mridul Seth <git@mriduls.com>
fadff9d to
de5b4a4
Compare
nstarman
approved these changes
Sep 3, 2024
Member
nstarman
left a comment
There was a problem hiding this comment.
LGTM. But a relevant maintainer should comment on the untested portions of the logger.
Member
|
I think it looks okay but I enabled |
Member
|
Thanks, all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #16060