Skip to content

MNT: Run PTH flake test in prep for supporting pathlib (astropy.logger)#16926

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:logger/rf/pth_checks
Sep 3, 2024
Merged

MNT: Run PTH flake test in prep for supporting pathlib (astropy.logger)#16926
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:logger/rf/pth_checks

Conversation

@neutrinoceros
Copy link
Contributor

Description

Extracted from #16060

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v7.0.0 milestone Sep 3, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review September 3, 2024 18:15
Copy link
Member

@nstarman nstarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But a relevant maintainer should comment on the untested portions of the logger.

@pllim pllim added the Extra CI Run cron CI as part of PR label Sep 3, 2024
@pllim
Copy link
Member

pllim commented Sep 3, 2024

I think it looks okay but I enabled Extra CI just to be sure.

@pllim pllim merged commit f5c2c4a into astropy:main Sep 3, 2024
@pllim
Copy link
Member

pllim commented Sep 3, 2024

Thanks, all!

@neutrinoceros neutrinoceros deleted the logger/rf/pth_checks branch September 3, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants