MNT: ignore PTH linting ruleset by subpackage instead of globally#16917
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
851af64 to
d0a22b6
Compare
astropy/_dev/scm_version.py
Outdated
| from setuptools_scm import get_version | ||
|
|
||
| version = get_version(root=pth.join("..", ".."), relative_to=__file__) | ||
| version = get_version(root=Path("../.."), relative_to=__file__) |
There was a problem hiding this comment.
I think this is OS dependent. .parent or .parents.
|
I think this one doesn't need a changelog entry, but obviously others, where there is an impact in what we accept, might. |
d0a22b6 to
142822c
Compare
pllim
left a comment
There was a problem hiding this comment.
LGTM except a minor comment. Thanks!
There was a problem hiding this comment.
Cannot really test this until next time it runs and has something to update.
Why call Path(project_file) twice instead of assigning it to variable?
There was a problem hiding this comment.
good catch. I imagine this change was originally obtained directly via ruff. Updated !
Co-authored-by: Mridul Seth <git@mriduls.com>
142822c to
bf903a4
Compare
Description
This is step 0 in my plan to revive #16060: I plan to re-issue this PR in smaller bits targetting specific subpackages to make it easier to cycle.
I intend to keep @MridulS as a commit co-author every step of the way :)