Skip to content

Set minimum pytest version to 8.0#16885

Closed
mhvk wants to merge 1 commit intoastropy:mainfrom
mhvk:pytest-8.0-minimum-version
Closed

Set minimum pytest version to 8.0#16885
mhvk wants to merge 1 commit intoastropy:mainfrom
mhvk:pytest-8.0-minimum-version

Conversation

@mhvk
Copy link
Copy Markdown
Contributor

@mhvk mhvk commented Aug 26, 2024

In recent tests, we are using exc.add_note(), which is available in python >=3.11. It turns out it is not supported by pytest < 8, however, so this PR increases the minimum pytest version to make it work.

Fixes #16884

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v7.0.0 milestone Aug 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are too fast! 😆

Please see my comment at #16884 (comment) . Thanks!

@mhvk
Copy link
Copy Markdown
Contributor Author

mhvk commented Aug 26, 2024

This PR is clearly incomplete -- all usage of PYTEST_LT_8_0 should be removed as well. So, let me close it.

@mhvk mhvk closed this Aug 26, 2024
@mhvk mhvk deleted the pytest-8.0-minimum-version branch August 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: "Exotic archs" has 3 failures with AssertionError: Regex pattern did not match.

2 participants