Skip to content

Fix comment added in gh-16878 [skip ci]#16881

Merged
pllim merged 1 commit intoastropy:mainfrom
mhvk:units-better-error-message-for-unitless-input-fixup
Aug 26, 2024
Merged

Fix comment added in gh-16878 [skip ci]#16881
pllim merged 1 commit intoastropy:mainfrom
mhvk:units-better-error-message-for-unitless-input-fixup

Conversation

@mhvk
Copy link
Copy Markdown
Contributor

@mhvk mhvk commented Aug 26, 2024

This pull request fixes a mistake in a comment added in #16878, noted by @maxnoe in #16878 (comment) - since it is in a comment, I skipped CI, though that also means @pllim likely needs to press the merge button -- sorry!

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Thanks!

p.s. Any org repo admin (usually CoCo and maybe a few others?) can do that too. ;)

@pllim pllim merged commit 584a2ee into astropy:main Aug 26, 2024
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release Bug labels Aug 26, 2024
@mhvk
Copy link
Copy Markdown
Contributor Author

mhvk commented Aug 26, 2024

Thanks! And sorry to always ping you...

@mhvk mhvk deleted the units-better-error-message-for-unitless-input-fixup branch August 26, 2024 19:10
@pllim
Copy link
Copy Markdown
Member

pllim commented Aug 26, 2024

No problem. I just want to clarify that there are others who can help if I do not respond fast enough. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Docs no-changelog-entry-needed units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants