Skip to content

BUG: Build all wheels on label event too#16855

Merged
pllim merged 1 commit intoastropy:mainfrom
pllim:build-all-wheels-on-label
Aug 19, 2024
Merged

BUG: Build all wheels on label event too#16855
pllim merged 1 commit intoastropy:mainfrom
pllim:build-all-wheels-on-label

Conversation

@pllim
Copy link
Member

@pllim pllim commented Aug 19, 2024

Description

Theoretically, if I open this PR first without "Build all wheels" label, and then add that label separately, all the wheels would build now.

Fixes #16853

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added the Build all wheels Run all the wheel builds rather than just a selection label Aug 19, 2024
@pllim
Copy link
Member Author

pllim commented Aug 19, 2024

Yup, I think it is working.

@pllim pllim marked this pull request as ready for review August 19, 2024 20:43
@pllim
Copy link
Member Author

pllim commented Aug 19, 2024

The fact that label alone triggered them is enough, no need to wait for completion, so I canceled the jobs. Will just merge since this should be uncontroversial.

@pllim pllim merged commit bbc6511 into astropy:main Aug 19, 2024
@pllim pllim deleted the build-all-wheels-on-label branch August 19, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Build all wheels Run all the wheel builds rather than just a selection dev-automation no-changelog-entry-needed Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: "Build all wheels" not triggering on PR on labeled event

1 participant