Skip to content

DOC: Add test runner limitation wrt asdf-astropy to Known Issues#16179

Merged
pllim merged 2 commits into
astropy:mainfrom
pllim:test-runner-known-issue
Mar 8, 2024
Merged

DOC: Add test runner limitation wrt asdf-astropy to Known Issues#16179
pllim merged 2 commits into
astropy:mainfrom
pllim:test-runner-known-issue

Conversation

@pllim

@pllim pllim commented Mar 7, 2024

Copy link
Copy Markdown
Member

Description

This pull request is to address the following:

The only thing that matters here is the RTD build, so I skipped other CI.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

wrt asdf-astropy to Known Issues. [ci skip]
@github-actions

github-actions Bot commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Mar 7, 2024

Copy link
Copy Markdown
Member Author

pre-commit.ci autofix

@WilliamJamieson WilliamJamieson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable compromise for now, especially if we move forward with #16177.

@pllim pllim merged commit b4272fd into astropy:main Mar 8, 2024
@pllim pllim deleted the test-runner-known-issue branch March 8, 2024 02:46
@pllim

pllim commented Mar 8, 2024

Copy link
Copy Markdown
Member Author

Thanks for the review!

d-giles referenced this pull request in d-giles/astropy-abdufork Jul 26, 2024
…179)

* DOC: Add test runner limitation
wrt asdf-astropy to Known Issues. [ci skip]

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running tests from astropy.test() fails when asdf-astropy is installed

2 participants