Backport PR #15948 on branch v6.0.x (RFC: make all MaskedNDArray.__wrap_array__'s helper functions return a (result, mask, out) tuple (fix compat with numpy dev))#15951
Merged
pllim merged 1 commit intoastropy:v6.0.xfrom Jan 25, 2024
Conversation
…'s helper functions return a (result, mask, out) tuple (fix compat with numpy dev)
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
@mhvk , just to make sure, is this safe to backport (i.e., no user-facing API or behavior changes)? |
Member
|
Not like we have a choice if we want 6.0.1 to be compatible with numpy 2.0. So merging but if someone disagrees, we can revert. |
Contributor
|
Indeed, this has no user-facing changes! Thanks for checking and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #15948: RFC: make all MaskedNDArray.wrap_array's helper functions return a (result, mask, out) tuple (fix compat with numpy dev)