Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
Author
|
The numpy-dev run still fails, because the NEP 50 changes are not yet in the nightly wheel. |
Member
|
Let's wait for the wheel then. Thanks! |
Member
|
dev deps passed now, so I am going to merge and kick off a wheel build here. Thanks!!! |
pllim
approved these changes
Oct 25, 2023
Contributor
Author
|
OK, let me know if there are any problems! (I was very happy with how few changes were necessary...) |
Member
|
Still more than I like but hopefully they ran out of stuff to refactor by now. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes should get us up to date to numpy-dev for the changes in casting done in numpy/numpy#23912 (following NEP 50). Also adds support (or, rather, indicate that we do not support) two string ufuncs for
Quantity.Will probably need to wait for the relevant numpy-dev wheels to come out, but at least one can test whether the tests still pass on regular numpy.