Skip to content

patch cosmo error seive#15399

Closed
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:cosmo-patch-seive
Closed

patch cosmo error seive#15399
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:cosmo-patch-seive

Conversation

@nstarman

Copy link
Copy Markdown
Member

Fixes #15315.
Not the most elegant solution, but fine for these purposes.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim

pllim commented Sep 27, 2023

Copy link
Copy Markdown
Member

Hmm... should we only do this when we bump Cython in pyproject.toml ? And we shouldn't do the bump in backport for v5.3.x.

@nstarman

Copy link
Copy Markdown
Member Author

IDK. You're right that this doesn't impact our supported version of Cython.

@pllim

pllim commented Sep 28, 2023

Copy link
Copy Markdown
Member

Cython 3 was only released 2 months ago. When should we bump it, @astropy/astropy-project-release-team ?

@saimn

saimn commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

I think we should use Cython 3 for 6.0, it may also be better for Numpy 2.0 support. See #15402

@pllim pllim mentioned this pull request Sep 28, 2023
1 task
@saimn saimn modified the milestones: v5.3.4, v5.3.5 Oct 3, 2023
@nstarman

nstarman commented Nov 3, 2023

Copy link
Copy Markdown
Member Author

@saimn Is this needed any more now that #15402 is merged?

@nstarman nstarman marked this pull request as ready for review November 3, 2023 20:50
@nstarman nstarman requested a review from a team as a code owner November 3, 2023 20:50
@saimn

saimn commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

@nstarman - your commit was included in #15402 so can be closed.

@saimn saimn closed this Nov 3, 2023
@nstarman nstarman deleted the cosmo-patch-seive branch November 4, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Cython3 chokes on astropy 5.3.3 (worked in 5.3.2)

3 participants