Skip to content

TST: Add back test removed in PR 15054 (pytest 8 compat)#15252

Merged
saimn merged 1 commit intoastropy:mainfrom
pllim:add-back-fits-test
Aug 30, 2023
Merged

TST: Add back test removed in PR 15054 (pytest 8 compat)#15252
saimn merged 1 commit intoastropy:mainfrom
pllim:add-back-fits-test

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Aug 30, 2023

Description

This pull request is to add back a test case that was accidentally removed in:

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added testing Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed Extra CI Run cron CI as part of PR labels Aug 30, 2023
@pllim pllim added this to the v6.0 milestone Aug 30, 2023
@pllim pllim mentioned this pull request Aug 30, 2023
Merged
2 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

This comment was marked as outdated.

Sign in to view
@pllim pllim marked this pull request as ready for review August 30, 2023 02:26
@pllim pllim requested a review from saimn as a code owner August 30, 2023 02:26
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Aug 30, 2023

CI passed. The change log job got stuck but shouldn't matter.

saimn
saimn approved these changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pllim !

@saimn saimn merged commit c3b34fe into astropy:main Aug 30, 2023
@pllim pllim deleted the add-back-fits-test branch August 30, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn approved these changes

Assignees

No one assigned

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Extra CI Run cron CI as part of PR io.fits no-changelog-entry-needed testing

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @saimn