Skip to content

Backport PR #15049: fix sign of w0wzCDM inv_efuncs pyx (v5.3.x)#15224

Merged
pllim merged 2 commits into
astropy:v5.3.xfrom
nstarman:auto-backport-of-pr-15049-on-v5.3.x
Aug 24, 2023
Merged

Backport PR #15049: fix sign of w0wzCDM inv_efuncs pyx (v5.3.x)#15224
pllim merged 2 commits into
astropy:v5.3.xfrom
nstarman:auto-backport-of-pr-15049-on-v5.3.x

Conversation

@nstarman

Copy link
Copy Markdown
Member

Backport of #15049

@nstarman nstarman added this to the v5.3.3 milestone Aug 23, 2023
@nstarman nstarman requested a review from pllim August 23, 2023 22:05
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@pllim pllim changed the title Backport PR #15049: fix sign of w0wzCDM inv_efuncs pyx Backport PR #15049: fix sign of w0wzCDM inv_efuncs pyx (v5.3.x) Aug 24, 2023
@pllim pllim added Manual Backport skip-basebranch-check Skip base branch check for direct backports labels Aug 24, 2023
@pllim

pllim commented Aug 24, 2023

Copy link
Copy Markdown
Member

Close/reopen to make bot happy

@pllim pllim closed this Aug 24, 2023
@pllim pllim reopened this Aug 24, 2023
@nstarman nstarman marked this pull request as ready for review August 24, 2023 17:56
@nstarman nstarman requested a review from a team as a code owner August 24, 2023 17:56

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim

pllim commented Aug 24, 2023

Copy link
Copy Markdown
Member

remote data failure unrelated.

@pllim pllim merged commit afeeaa6 into astropy:v5.3.x Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cosmology Manual Backport skip-basebranch-check Skip base branch check for direct backports

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants