Skip to content

use cdef double over cdef#15076

Merged
saimn merged 1 commit into
astropy:mainfrom
nstarman:cosmo-cdef-double
Jul 27, 2023
Merged

use cdef double over cdef#15076
saimn merged 1 commit into
astropy:mainfrom
nstarman:cosmo-cdef-double

Conversation

@nstarman

@nstarman nstarman commented Jul 19, 2023

Copy link
Copy Markdown
Member

From: #15049

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v6.0 milestone Jul 19, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman requested a review from saimn July 19, 2023 00:32
@nstarman nstarman marked this pull request as ready for review July 21, 2023 16:50
@nstarman nstarman requested a review from a team as a code owner July 21, 2023 16:50
@nstarman nstarman added the Extra CI Run cron CI as part of PR label Jul 21, 2023
@nstarman

Copy link
Copy Markdown
Member Author

Is a changelog entry needed? Is this technically a bug fix that should be backported?

@saimn

saimn commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

It was not a bug (a Python object was used instead of a c variable), maybe just a small perf improvement.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt? I'll let someone who knows Cython to merge.

@saimn

saimn commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Ok, let's merge then, thanks @nstarman.

@saimn saimn merged commit 901598b into astropy:main Jul 27, 2023
@nstarman nstarman deleted the cosmo-cdef-double branch July 27, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants