Updated release procedure to no longer mention LTS (as per APE 21) by astrofrog · Pull Request #14713 · astropy/astropy

astrofrog · 2023-04-28T20:37:16Z

This is a companion to astropy/astropy-APEs#82 which proposes no longer having LTS releases.

As part of APE 21 we are also advocating using x.x.0 version number formats for the first minor/major release in each cycle as this is more standard practice (the only place where I think we can keep the x.x version numbers is for the filenames and titles of the What's new pages)

github-actions · 2023-04-28T20:38:01Z

github-actions · 2023-04-28T20:38:07Z

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

pllim

Thanks!

docs/development/releasing.rst

pllim · 2023-04-29T01:00:14Z

docs/development/releasing.rst

-#. If this is a release of the current release (i.e., not an LTS supported along
-   side a more recent version), update the "stable" branch to point to the new
-   release::
+#. Update the "stable" branch to point to the new release::


Do we still need stable branch?

No I think we can remove this if we set up the automatic updating of stable on RTD

It sounds like this should work by default but I guess we will need to remove the stable branch in our repo and probably also wipe stable in RTD after we've done that and remove the explicitly specified stable version.

pllim · 2023-04-29T01:00:45Z

docs/development/releasing.rst

      $ git reset --hard v<version>
      $ git push upstream stable --force

-#. If this is an LTS release (whether or not it is being supported alongside


Does this mean we delete the LTS branch from repo after APE 21 is accepted?

No because we might break old links I think? We can just leave the branch frozen?

Don't we need the stable branch for RTD ? (https://docs.astropy.org/en/stable/)

In my projects without a stable branch, the "stable" on RTD automagically picks up the latest release. 🤷

Do you plan to delete the stable branch altogether?

Right, then we should delete the stable branch.
https://docs.readthedocs.io/en/stable/versions.html

When should I do that? Now or when you cut v6.0 ?

Hmm yeah we can probably do that now.

Done. stable is gone.

pllim · 2023-04-29T01:01:57Z

docs/development/releasing.rst

-   Typically, you should wait to make sure ``conda-forge`` and possibly
-   ``conda`` works before sending out the public announcement
-   (so that users who want to try out the new version can do so with ``conda``).
+   merge. When the ``conda-forge`` package is ready, email the Anaconda


Anything else will change on the conda side without LTS, @mwcraig ?

pllim · 2023-04-29T01:03:39Z

docs/index.rst

   :maxdepth: 1

   whatsnew/index
-   lts_policy


Do we want to keep this page but on that page link to APE 21 and tell people that LTS is no more?

Yes we could do this, will update

pllim · 2023-05-31T14:24:47Z

@astrofrog , can you please rebase and take this out of draft? APE 21 is accepted.

astrofrog · 2023-06-01T15:53:54Z

@pllim - done!

pllim

Thanks!

WilliamJamieson

I noticed one discrepancy between the changes from astropy/astropy-APEs#82 and the changes here

docs/development/releasing.rst

docs/lts_policy.rst

pllim · 2023-10-04T20:50:51Z

@astrofrog , please rebase. Thanks!

pllim · 2023-10-27T16:30:06Z

@astrofrog , any chance you can wrap this up soon? 🙏

astrofrog · 2023-10-27T16:31:17Z

Will do on Monday

…elease numbers for the first feature release in each cycle

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

…onger exist

Co-authored-by: William Jamieson <wjamieson@stsci.edu>

astrofrog · 2023-10-27T20:13:45Z

Rebased - someone should read over the changes carefully once more to be sure that this is all fine now.

pllim · 2023-10-27T20:17:14Z

@saimn would be the best person, but @WilliamJamieson also requested changes before.

saimn

Sounds good to me!

Request was addressed.

github-actions bot added Docs Release labels Apr 28, 2023

pllim added this to the v6.0 milestone Apr 29, 2023

pllim added the no-changelog-entry-needed label Apr 29, 2023

pllim reviewed Apr 29, 2023

View reviewed changes

pllim requested a review from saimn April 29, 2023 01:03

pllim mentioned this pull request May 12, 2023

APE 21: APE on ending long term support releases + Updates to APE 2 to reflect new release cycle without LTS astropy/astropy-APEs#82

Merged

1 task

pllim changed the title ~~Updated release procedure to no longer mention LTS~~ Updated release procedure to no longer mention LTS (as per APE 21) May 31, 2023

astrofrog marked this pull request as ready for review June 1, 2023 15:53

astrofrog force-pushed the docs-remove-lts branch from 2e863e3 to f764111 Compare June 1, 2023 15:53

pllim approved these changes Jun 1, 2023

View reviewed changes

pllim enabled auto-merge June 1, 2023 15:55

pllim disabled auto-merge June 1, 2023 16:08

WilliamJamieson previously requested changes Jun 2, 2023

View reviewed changes

docs/development/releasing.rst Outdated Show resolved Hide resolved

hamogu reviewed Jun 7, 2023

View reviewed changes

docs/lts_policy.rst Show resolved Hide resolved

astrofrog and others added 2 commits October 27, 2023 21:08

Updated release procedure to no longer mention LTS and to use x.x.0 r…

6e06a76

…elease numbers for the first feature release in each cycle

Apply suggestions from @pllim

e21229a

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

astrofrog force-pushed the docs-remove-lts branch from f764111 to 4943808 Compare October 27, 2023 20:10

astrofrog added 2 commits October 27, 2023 21:12

Add back LTS policy page as a place to mention that LTS releases no l…

3e8b35d

…onger exist

Fixed link

9f2a18e

astrofrog force-pushed the docs-remove-lts branch from 4943808 to 9f2a18e Compare October 27, 2023 20:12

Apply suggestions from code review

d247ff2

Co-authored-by: William Jamieson <wjamieson@stsci.edu>

saimn approved these changes Oct 28, 2023

View reviewed changes

saimn merged commit 1a1b689 into astropy:main Oct 28, 2023

Uh oh!

Conversation

astrofrog commented Apr 28, 2023

Uh oh!

github-actions bot commented Apr 28, 2023

Uh oh!

github-actions bot commented Apr 28, 2023

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pllim commented May 31, 2023

Uh oh!

astrofrog commented Jun 1, 2023

Uh oh!

pllim left a comment

Choose a reason for hiding this comment

Uh oh!

WilliamJamieson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pllim commented Oct 4, 2023

Uh oh!

pllim commented Oct 27, 2023

Uh oh!

astrofrog commented Oct 27, 2023

Uh oh!

astrofrog commented Oct 27, 2023

Uh oh!

pllim commented Oct 27, 2023

Uh oh!

saimn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants