Skip to content

Manual backport of #13892 onto v5.0.x#13895

Merged
pllim merged 1 commit intoastropy:v5.0.xfrom
WilliamJamieson:backport/13892
Oct 25, 2022
Merged

Manual backport of #13892 onto v5.0.x#13895
pllim merged 1 commit intoastropy:v5.0.xfrom
WilliamJamieson:backport/13892

Conversation

@WilliamJamieson
Copy link
Contributor

Description

Manual backport of #13892.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented Oct 25, 2022

No need to wait for cron. They take too long.

@pllim pllim merged commit d72ab6b into astropy:v5.0.x Oct 25, 2022
@pllim pllim changed the title Manual backport of #13892 Manual backport of #13892 onto v5.0.x Oct 25, 2022
@WilliamJamieson WilliamJamieson deleted the backport/13892 branch October 25, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants