Add coverage to minimal dependency test#12193
Conversation
|
Thanks, I'll have a look next week but people who are more familiar with codecov are welcome to review too! |
|
Same here! |
|
Just to check, what is the motivation for this? Ideally we would measure coverage on all jobs but we don't for performance reasons as it adds a significant overhead. I'm curious what we gain by adding it to this job? |
|
There was confusion when a test that only runs in a minimal dependency setting gets reported as not covered even though there is a test. |
|
Ok thanks for the background! Maybe a comment should be added in the CI config to explain this. Is the addition of -clocale needed? If not, maybe just add -cov? |
|
I think the |
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Done. Added a short note about running tests without scipy. |
pllim
left a comment
There was a problem hiding this comment.
LGTM. Let's deploy and see what happens.
|
Does not look like the overhead is all that large – only a few minutes difference in testing times, at most. |
|
Wow, an hour! I am not sure... I don't think I ever tried to run |
|
Yup, I see 1.5 hours on Linux. Must be the overhead of checking for dangling file pointers in the test runner. I don't see it being stuck on any one job. Not sure what we can do about that.
|
Also add coverage report to minimal dependency test.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.