Skip to content

Get wcslib-7.7 from bullseye-backports for non-x86 CI tests#12167

Merged
pllim merged 1 commit intoastropy:mainfrom
olebole:bullseye-backports
Sep 14, 2021
Merged

Get wcslib-7.7 from bullseye-backports for non-x86 CI tests#12167
pllim merged 1 commit intoastropy:mainfrom
olebole:bullseye-backports

Conversation

@olebole
Copy link
Member

@olebole olebole commented Sep 14, 2021 •
edited by pllim
Loading

Description

wcslib backports are now built on many platforms (except for MIPS, which is not used here, right?). This PR installs this wcslib on the weekly (non-x86) CI tests, like 0ff2f4f.

Fixes #12144

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added Extra CI Run cron CI as part of PR no-changelog-entry-needed labels Sep 14, 2021
@pllim pllim added this to the v5.0 milestone Sep 14, 2021
@pllim
Copy link
Member

pllim commented Sep 14, 2021

Thanks! I enabled cron jobs here. 🤞

Milestone here is to match #11934 .

@pllim
Copy link
Member

pllim commented Sep 14, 2021

@olebole , any advise?

The following packages have unmet dependencies:
 wcslib-dev : Depends: libwcs7 (= 7.7+ds-1~bpo11+1) but 7.4+ds-2 is to be installed
              Recommends: giza-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

@olebole
Copy link
Member Author

olebole commented Sep 14, 2021

The problem was that it doesn't pull the libwcs7 dependency from the backports; they need to be installed explicitly.

@pllim
Copy link
Member

pllim commented Sep 14, 2021

pyinstaller and linkcheck failures are unrelated.

pllim
pllim approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exotic arch jobs are green again. Thank you, @olebole !

@pllim pllim merged commit becfacf into astropy:main Sep 14, 2021
This was referenced Dec 15, 2021
Merged
Closed
@olebole olebole deleted the bullseye-backports branch February 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

TST: Ensure exotic archs jobs in weekly cron pass again with bullseye wcslib backport

2 participants

@olebole @pllim