Updates in main for 4.3.1#12046
Merged
Merged
Conversation
pllim
approved these changes
Aug 12, 2021
pllim
left a comment
Member
There was a problem hiding this comment.
I don't see anything too shocking but I'll defer to others on the towncrier logistics.
saimn
approved these changes
Aug 13, 2021
saimn
left a comment
Contributor
There was a problem hiding this comment.
Yes I think we want to delete the fragments after each minor release, so LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the changelog, towncrier fragments, and IERS files to match 4.3.1.
To be honest, I'm not sure what fraction of these we want, though, given the towncrier machinery! Did we think to only delete fragments at the next major release, or at every bugfix release like this?
Note also some of this had to be done manually because if some hiccups involving the backport bot which meant that the history leading up to 4.3.1 on v4.3.x has multiple commits instead of a single unified. Hopefully this will not be neccessary in the future if we can resolve #11847 , but the above question applies even if it's just a
towncriercall vs the manual work I had to do here.