indentation fix#11974
Merged
Merged
Conversation
Cadair
approved these changes
Jul 26, 2021
Member
|
Ops... basebranch check too aggressive but we don't need the CI anyway and RTD passed. |
Member
Author
Member
|
P.s. Not sure what "harmonize with main" means here, as we simply link to old "what's new" via URL from main anyway... |
Member
Author
|
@pllim - Yeah, now that you mention it I think the only thing needed for harmonizing is that link and updating the release date. But the link may depend on the solution here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, the read the docs failed due to an indentation mistake here 🤦 . This should fix it, but going to have to think about what to do here. But should get this into the v4.3.x branch before I harmonize with
main