Fix various typos#11967
Conversation
There was a problem hiding this comment.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please leave a comment mentioning our software support engineer @embray, or send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.
|
There are conflicts now with change log due to #11856 in the v4.3 release process (i.e., bad timing). Needs another rebase and certainly a squash. |
|
@pllim I didn't see any necessity to squash.. did i miss something? I've rebased and force pushed. |
|
@nstarman , not sure if that checklist is necessary here, as this is a simple typo fix PR. It is on my todo list to do one last review before approving and merging, just haven't got around to it yet. That said, such a checklist would be useful for more complicated PR that touches multiple subpackages. 😸 |
|
Thank goodness it's not a complicated PR then..yikes |
e15c289 to
8a1ba3e
Compare
pllim
left a comment
There was a problem hiding this comment.
Caught a weird typo introduced by the checker that is supposed to fix typo. 🤔
No need to squash this time.
|
@luzpaz, rebase and resolve conflicts? This PR still has time to get into v5.0, which would be quite nice. |
|
Rebased but left unsquashed |
bd3b67b to
95d4f33
Compare
|
Squashed and rebased |
|
The RTD failures might disappear if this PR is rebased again. We had a recent PR to address the |
Found via `codespell -q 3 -S ./cextern,./astropy/extern -L ba,coo,dum,hist,nd` Revert extern/ commit Update astropy/units/function/core.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> Update astropy/uncertainty/core.py Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
|
@nstarman rebased |
@pllim. I think @luzpaz has sorted and squashed the relevant problems -- the codecov patch error is not relevant. |
|
p.s. You win the most labels contest. |
Found via
codespell -q 3 -S ./cextern,./astropy/extern -L ba,coo,dum,hist,nd