Skip to content

Dropping support for numpy 1.17#11935

Merged
pllim merged 4 commits intoastropy:mainfrom
bsipocz:numpy_117_drop
Jul 12, 2021
Merged

Dropping support for numpy 1.17#11935
pllim merged 4 commits intoastropy:mainfrom
bsipocz:numpy_117_drop

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Jul 9, 2021 •
edited by pllim
Loading

Second part of #11934 due to changelog issues , dropping numpy

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@bsipocz bsipocz added this to the v5.0 milestone Jul 9, 2021
@bsipocz bsipocz mentioned this pull request Jul 9, 2021
Merged
10 tasks
mhvk
mhvk approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Obviously, a failure with a matplotlib version test, but otherwise it all looks good. Thanks!

@bsipocz
Copy link
Member Author

bsipocz commented Jul 10, 2021

yes, those tests will be modified in #11934, so I suppose I'll just hack it around here to mimic a passing status and rebase that other PR...

@pllim
Copy link
Member

pllim commented Jul 12, 2021

@bsipocz , are you sure you don't want to merge this and #11934 back into one PR? I think you mentioned on Slack that you found a workaround for the change log problem?

@pllim pllim self-requested a review July 12, 2021 18:15
@bsipocz
Copy link
Member Author

bsipocz commented Jul 12, 2021

@pllim - Yes, I would do that if I were starting it again, but this part can be now merged as is, and the other PR needs more work/wait for the mpl test images. So in the interest of having the trivial part into the codebase sooner, I would suggest to merge this now, and I rebase the other PR on top.

pllim
pllim approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's get this in then. Thank you!

@pllim pllim merged commit 0c2d01c into astropy:main Jul 12, 2021
@hamogu hamogu mentioned this pull request Aug 2, 2021
Merged
9 tasks
@bsipocz bsipocz mentioned this pull request Aug 10, 2021
Merged
12 tasks
@bsipocz bsipocz deleted the numpy_117_drop branch September 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

@mhvk mhvk mhvk approved these changes

Assignees

No one assigned

Labels

Docs installation testing units utils.masked utils

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bsipocz @pllim @mhvk