Skip to content

change actions to trigger workflows on this branch#11846

Merged
eteq merged 2 commits into
astropy:v4.3.xfrom
eteq:update-actions-for-branch
Jun 15, 2021
Merged

change actions to trigger workflows on this branch#11846
eteq merged 2 commits into
astropy:v4.3.xfrom
eteq:update-actions-for-branch

Conversation

@eteq

@eteq eteq commented Jun 14, 2021

Copy link
Copy Markdown
Member

I think what I should have done was make this change at the time I cut the new v4.3.x branch. @pllim can you confirm that was the intent? (or at least that this makes sense?)

@eteq eteq added the Affects-dev PRs and issues that do not impact an existing Astropy release label Jun 14, 2021
@eteq eteq added this to the v4.3 milestone Jun 14, 2021
@eteq eteq requested a review from pllim June 14, 2021 21:52
@eteq eteq added the testing label Jun 14, 2021
@eteq eteq mentioned this pull request Jun 14, 2021
Closed
16 tasks
@eteq eteq added skip-basebranch-check Skip base branch check for direct backports no-changelog-entry-needed labels Jun 14, 2021
pllim
pllim reviewed Jun 14, 2021
View reviewed changes
Comment thread .github/workflows/ci_workflows.yml Outdated
@eteq

eteq commented Jun 14, 2021

Copy link
Copy Markdown
Member Author

@pllim , can you advise if I am confused about how to use skip-basebranch-check? Or if I should be updating... something about that for the new branch too?

@eteq @pllim
Update .github/workflows/ci_workflows.yml
a281d1f 
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@pllim

pllim commented Jun 14, 2021

Copy link
Copy Markdown
Member

The skip-basebranch-check check logic only updates when you do a new push, which you just did, so it should pass now.

I had a reason to not have labeled trigger it but I don't quite remember now. Gotta dig at my original PR to find out if you must know.

@pllim

pllim commented Jun 14, 2021

Copy link
Copy Markdown
Member

p.s. It should skip base branch check automatically if the bot does the backport. 😉

astropy/.github/workflows/ci_workflows.yml

Lines 28 to 31 in 9819e92

if (pr.user.login === 'meeseeksmachine') {
core.info(`Base branch check is skipped since this is auto-backport by ${pr.user.login}`);
return;
}

@pllim pllim added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Jun 14, 2021
@eteq

eteq commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

The failure is real, but not related to this PR. So I'm going to go ahead and merge just to make sure this triggers the CI as expected. Thanks for the clarification, @pllim !

@eteq eteq merged commit 5a7b13d into astropy:v4.3.x Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports testing zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

2 participants

@eteq @pllim