-
-
Notifications
You must be signed in to change notification settings - Fork 2k
TST: xfail flatiter test for s390x and numpy<1.22 #11818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mhvk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
Thanks for the approval! We'll find out in a few hours. 😸 |
|
Darn, it the |
| from astropy import units as u | ||
| from astropy.utils.compat import NUMPY_LT_1_22 | ||
|
|
||
| IS_S390X = os.environ.get('ARCH_ON_CI', 'normal') == 's390x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be this line...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the xfail not working? 🤯
ARCH_ON_CI: s390x
Numpy: 1.20.3
|
If we're sure it fails because it is big-endian, one could do |
|
@mhvk , good idea. Let's try that but have to wait a few more hours. 😿 |
|
@mhvk , finally green! Should I squash and |
|
Let's go for it! Thanks again! |
Description
This pull request is to fix #11804 .
A direct follow-up of #11796. Also see numpy/numpy#19153.
p.s. Ignore the
linkcheckfailure.