Skip to content

Conversation

@nstarman
Copy link
Member

@nstarman nstarman commented Jun 1, 2021

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@github-actions github-actions bot added the units label Jun 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added the Extra CI Run cron CI as part of PR label Jun 1, 2021
@mhvk
Copy link
Contributor

mhvk commented Jun 1, 2021

OK, so this is a numpy issue. Do you want to raise an issue there or prefer that I do it? I think it is most likely because it is big-endian, though obviously not 100% sure.

I guess this also means we should disable the test on s390x for now, since it will be a while before the corresponding distribution has a fixed numpy.

@nstarman
Copy link
Member Author

nstarman commented Jun 2, 2021

Thanks. I've submitted numpy/numpy#19153 and mentioned you both on it.

I guess this PR should be made #upstream-fix-required ?

@nstarman nstarman changed the title test corresponding numpy flat numpy.flatiter index does not update on big-endian machines Jun 2, 2021
@pllim
Copy link
Member

pllim commented Jun 2, 2021

This PR actually can be closed now that the point is proven, but I'll mark #11804 as upstream fix required. Thanks!

@pllim pllim closed this Jun 2, 2021
@nstarman nstarman deleted the tst_11804 branch June 2, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra CI Run cron CI as part of PR units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants