Manual backport for PR 11622#11652
Closed
pllim wants to merge 1 commit into
Closed
Conversation
7a68091 to
7c5dfb9
Compare
Member
Author
|
Azure wheel failure is unrelated. |
pllim
commented
Apr 27, 2021
pllim
commented
Apr 27, 2021
pllim
commented
Apr 27, 2021
|
|
||
| {%endif%} | ||
| ``astropy``, such as an affiliated package, consider installing ``astropy`` | ||
| into a :ref:`virtualenv <astropy-dev:virtual_envs>`. |
Member
Author
There was a problem hiding this comment.
This rendered correctly to https://docs.astropy.org/en/latest/development/workflow/virtual_pythons.html#virtual-envs
pllim
commented
Apr 30, 2021
pllim
left a comment
Member
Author
There was a problem hiding this comment.
I can confirm that this renders for "stable" as expected. I will remove temporary commits and squash. Once I do that, RTD will fail again until #11466 is backported. Also, even if not, the rendering will be misleading because dev will resolve to True again until a release is cut.
tl;dr -- Just trust me.
Co-authored-by: Erik M. Bray <erik.m.bray@gmail.com>
e16ba2d to
2b064c4
Compare
Member
|
It looks OK now? |
Member
Author
I think so, but I'll leave it to the release manager to merge. |
Member
|
Oops I backported this manually/locally in 0e44d7c so I think we can close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a manual backport for #11622 . I am trying to see if the RTD job here points to "astropy-dev" as expected, since the doc here is not considered to be "dev".
I also noticed that
git cherry-pickresulted in conflict (probably because LTS doc and dev doc have diverged so much), so this manual backport is unavoidable. But feel free to close without merge if the release manager finds otherwise.DO NOT MERGE until after #11622 is merged.
TODO