Skip to content

move rst_epilog subs and links to file#11624

Merged
adrn merged 1 commit into
astropy:mainfrom
nstarman:docs_sep_out_link
Apr 22, 2021
Merged

move rst_epilog subs and links to file#11624
adrn merged 1 commit into
astropy:mainfrom
nstarman:docs_sep_out_link

Conversation

@nstarman

Copy link
Copy Markdown
Member

Description

@embray @mhvk, as suggested. I agree this looks better.

@pllim : no-changelog-needed ? v4.3 ? Thanks!

@adrn adrn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Small typo here though (see comment)

Comment thread docs/conf.py Outdated
Suggested by @embray

Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
@nstarman nstarman force-pushed the docs_sep_out_link branch from 5952f31 to f588303 Compare April 22, 2021 16:37
@adrn

adrn commented Apr 22, 2021

Copy link
Copy Markdown
Member

(BTW: you could have added [ci skip] to your commit message, which cancels all GH actions tests but still runs the circleci/readthedocs tests.)

@pllim

pllim commented Apr 22, 2021

Copy link
Copy Markdown
Member

Re: skip ci -- CircleCI theoretically would get skipped too but I notice that they don't always. 🤷 RTD does not skip.

@adrn adrn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this follow-up!

@adrn adrn merged commit 9d8014c into astropy:main Apr 22, 2021
@nstarman nstarman deleted the docs_sep_out_link branch April 22, 2021 17:29
@mhvk

mhvk commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Nice! Perhaps should have been a .rst filetype, but not a big deal.

@nstarman

Copy link
Copy Markdown
Member Author

We actually can't use this in the docs or even transclude this since rst_epilog would attach it to itself and error from duplicate definitions! I think .txt obviates this and the orphan rst file problem.

@mhvk

mhvk commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Ah, makes sense, thanks!

@embray

embray commented Apr 26, 2021

Copy link
Copy Markdown
Member

Thanks for the quick turnaround on this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants