Fix regression for np.diff(time) and np.sum(timedelta) no longer working #10502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that, e.g., `np.diff(time)` will continue to return an object array with `TimeDelta` instances.
Contributor
Author
|
Thanks. It probably was a mistake, though it is also not good to rely on a private numpy implementation detail... The problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10337, an
__array_function__override was introduced, which allows some numpy functions to behave as expected onSkyCoordandTime. It was a strict whitelist, however, which breaks numpy functions that sort-of worked already (sort-of, since often an object array was returned).This PR returns to the old behaviour by passing on arguments to bare numpy function if it is not among the known functions.
fixes #10501
@taldcroft - I must admit I had no idea that
np.diff(time)andnp.sum(timedelta)even worked (if very slowly). Obviously, the final goal should be to support those properly, but this PR is just to fix the regression caused by #10337.