Skip to content

Conversation

@pllim
Copy link
Member

@pllim pllim commented Jun 8, 2020

Description

This pull request is to address problem reported in #10311 (comment) with no able to run a test without accessing internet.

This is a follow-up of #10337.

@pllim
Copy link
Member Author

pllim commented Jun 8, 2020

Something funky is going on because I can't reproduce this locally. I did stumble across #10471 though.

@pllim pllim requested a review from mhvk June 8, 2020 21:30
@pllim pllim modified the milestones: v4.1.1, v4.2 Jun 8, 2020
@pllim pllim marked this pull request as ready for review June 8, 2020 21:31
def setup_class(cls):
# This is to be consistent with setting in astropy/conftest.py
# that somehow is not getting picked up.
iers_conf.auto_download = False
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sure what happened: Either it is not picking up setting from astropy/conftest.py or something else is overwriting the setting. But forcing it (again) here seems to work.

@pllim
Copy link
Member Author

pllim commented Jun 8, 2020

I am expecting the Windows job to fail from #10471 but the html-docs failure is surprising.

Warning, treated as error:
 
autodoc: failed to import method '__call__' from module 'keyword'; the following exception was raised:
 
Traceback (most recent call last):
 
  File "/home/circleci/project/.tox/build_docs/lib/python3.7/site-packages/sphinx/util/inspect.py", line 323, in safe_getattr
 
    return getattr(obj, name, *defargs)
 
AttributeError: module 'keyword' has no attribute '__call__'

html-docs failure is not related, see #10473

@mhvk
Copy link
Contributor

mhvk commented Jun 8, 2020

Thanks! Though it is very puzzling indeed; the whole beauty was to make it unnecessary to set it in tests individually... I think in my local trial, I also didn't have the problem, but now wonder if perhaps I was not running the whole test suite. Will check.

@pllim
Copy link
Member Author

pllim commented Jun 8, 2020

Ah, interesting, the failure I reported in #10471 is not Windows-specific. See https://travis-ci.org/github/astropy/astropy/jobs/696220533 (Python 3.6 with oldest supported version of all dependencies)

@mhvk
Copy link
Contributor

mhvk commented Jun 9, 2020

So, this is really weird: if I just remove remote_data and do not apply the fix you have here, I do reproduce the test failure, that internet gets accessed with tox -e test. If confirm this if I then do

cd .tox/test
source bin/activate
pytest --pyargs astropy

However, if I next do

pytest --pyargs astropy -P coordinates

I do not get the failure!

@mhvk
Copy link
Contributor

mhvk commented Jun 9, 2020

Ah, getting somewhere:

pytest --pyargs astropy -P config,coordinates

does lead to failure. Maybe config messes up the configuration?!

@mhvk
Copy link
Contributor

mhvk commented Jun 9, 2020

Fix in #10474! Now your previous work comes to its full use - see how many remote_data were removed!!!

@pllim
Copy link
Member Author

pllim commented Jun 9, 2020

Thank you very much, @mhvk ! I'll have a look at #10474 after putting out the html-docs fire.

@pllim pllim closed this Jun 9, 2020
@pllim pllim deleted the tst-no-remote branch June 9, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants