-
-
Notifications
You must be signed in to change notification settings - Fork 2k
EXP: Run TestManipulation without remote data #10469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Something funky is going on because I can't reproduce this locally. I did stumble across #10471 though. |
| def setup_class(cls): | ||
| # This is to be consistent with setting in astropy/conftest.py | ||
| # that somehow is not getting picked up. | ||
| iers_conf.auto_download = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sure what happened: Either it is not picking up setting from astropy/conftest.py or something else is overwriting the setting. But forcing it (again) here seems to work.
|
I am expecting the Windows job to fail from #10471 but the
|
|
Thanks! Though it is very puzzling indeed; the whole beauty was to make it unnecessary to set it in tests individually... I think in my local trial, I also didn't have the problem, but now wonder if perhaps I was not running the whole test suite. Will check. |
|
Ah, interesting, the failure I reported in #10471 is not Windows-specific. See https://travis-ci.org/github/astropy/astropy/jobs/696220533 (Python 3.6 with oldest supported version of all dependencies) |
|
So, this is really weird: if I just remove However, if I next do I do not get the failure! |
|
Ah, getting somewhere: does lead to failure. Maybe config messes up the configuration?! |
|
Fix in #10474! Now your previous work comes to its full use - see how many |
Description
This pull request is to address problem reported in #10311 (comment) with no able to run a test without accessing internet.
This is a follow-up of #10337.