Fix new failure of spectral coord test because of quantity_input changes#10274
Merged
mhvk merged 1 commit intoastropy:masterfrom May 2, 2020
Merged
Fix new failure of spectral coord test because of quantity_input changes#10274mhvk merged 1 commit intoastropy:masterfrom
mhvk merged 1 commit intoastropy:masterfrom
Conversation
mhvk
approved these changes
May 2, 2020
Contributor
mhvk
left a comment
There was a problem hiding this comment.
I'm going ahead and approve + merge this trivial change since it is holding up my PR!
Contributor
|
p.s. We probably should stop matching whole error messages... (though obviously this was an unfortunate coincidence!) |
Contributor
|
p.s. Thanks for the very quick fix, @adrn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of two merged PRs (SpectralCoord and changes to quantity_input_) that weren't consistent, travis is now failing. This should fix it!