DO NOT MERGE TST: testing upstream ci-helpers by bsipocz · Pull Request #10237 · astropy/astropy

bsipocz · 2020-04-30T07:27:51Z

This PR is to smoke out issues around the removal of the pytest limitation upstream. Do not merge it.

Failures are expected based on experiences with tests run locally.

bsipocz · 2020-04-30T07:58:45Z

Oh, wow, interesting new error due to the infrastructure revamp . I suppose it means we better get #9965 finished up and merged.

cc @eteq @Cadair @astrofrog to have a look at the failure: https://travis-ci.org/github/astropy/astropy/jobs/681367964#L416

============================= test session starts ==============================

platform linux -- Python 3.8.1, pytest-5.4.1, py-1.8.1, pluggy-0.13.1

cachedir: .tox/py38-test-alldeps/.pytest_cache

Running tests with Astropy version 4.1.dev1225+g65b141418.

Running tests in astropy docs.

Date: 2020-04-30T07:47:35

Platform: Linux-5.0.0-1031-gcp-x86_64-with-glibc2.2.5

Executable: /home/travis/build/astropy/astropy/.tox/py38-test-alldeps/bin/python

Full Python Version: 

3.8.1 (default, Dec 20 2019, 10:06:11) 

[GCC 7.4.0]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8

byteorder: little

float info: dig: 15, mant_dig: 15

Package versions: 

Numpy: 1.18.3

Scipy: 1.4.1

Matplotlib: 3.2.1

h5py: 2.10.0

Pandas: 1.0.3

Using Astropy options: remote_data: none.

rootdir: /home/travis/build/astropy/astropy, inifile: setup.cfg

plugins: hypothesis-5.10.4, remotedata-0.3.2, cov-2.8.1, filter-subpackage-0.1.1, openfiles-0.5.0, astropy-header-0.1.2, forked-1.1.3, xdist-1.31.0, doctestplus-0.6.0, arraydiff-0.3, asdf-2.6.0

collected 15004 items / 5 errors / 14999 selected                              

==================================== ERRORS ====================================

_ ERROR collecting .tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/_erfa/setup_package.py _

../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/_erfa/setup_package.py:9: in <module>

    from extension_helpers import import_file

E   ModuleNotFoundError: No module named 'extension_helpers'

_ ERROR collecting .tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/io/fits/setup_package.py _

../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/io/fits/setup_package.py:12: in <module>

    from extension_helpers import pkg_config, get_compiler

E   ModuleNotFoundError: No module named 'extension_helpers'

_ ERROR collecting .tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/modeling/setup_package.py _

../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/modeling/setup_package.py:9: in <module>

    from extension_helpers import import_file

E   ModuleNotFoundError: No module named 'extension_helpers'

_ ERROR collecting .tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/utils/xml/setup_package.py _

../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/utils/xml/setup_package.py:10: in <module>

    from extension_helpers import pkg_config

E   ModuleNotFoundError: No module named 'extension_helpers'

_ ERROR collecting .tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/wcs/setup_package.py _

../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/wcs/setup_package.py:16: in <module>

    from extension_helpers import import_file, write_if_different, get_compiler, pkg_config

E   ModuleNotFoundError: No module named 'extension_helpers'

=========================== short test summary info ============================

ERROR ../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/_erfa/setup_package.py

ERROR ../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/io/fits/setup_package.py

ERROR ../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/modeling/setup_package.py

ERROR ../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/utils/xml/setup_package.py

ERROR ../../.tox/py38-test-alldeps/lib/python3.8/site-packages/astropy/wcs/setup_package.py

!!!!!!!!!!!!!!!!!!! Interrupted: 5 errors during collection !!!!!!!!!!!!!!!!!!!!

============================== 5 errors in 24.28s ==============================

ERROR: InvocationError for command /home/travis/build/astropy/astropy/.tox/py38-test-alldeps/bin/pytest --pyargs astropy /home/travis/build/astropy/astropy/docs --durations=50 (exited with code 2)

py38-test-alldeps: Shutting down tox-pypi-filter server

___________________________________ summary ____________________________________

ERROR:   py38-test-alldeps: commands failed

The command "if [ $SETUP_METHOD == 'tox' ]; then pip install tox; tox $TOXARGS -- $TOXPOSARGS; else python3 -m venv --system-site-packages tests; source tests/bin/activate; pip3 install -e .[test]; pytest-3; fi" exited with 1.

Done. Your build exited with 1.

bsipocz · 2020-04-30T08:00:33Z

(I added the milestone and the critical label as this should be attended before the release and either fixed or argued why it's not a real issue)

mhvk · 2020-05-03T14:36:09Z

Hmm, sounds like I removed a milestone wrongly elsewhere... Will leave this in place. Sadly not sure I can help, but if you need testing or so, let me know.

bsipocz · 2020-05-05T01:43:07Z

I've just released doctestplus 0.6.1, so this should now work. If @pllim you could give it a look, too whether everything seems to work with pytest 5.4

pllim · 2020-05-05T02:40:45Z

Yay! All green except the remote data tests that are unrelated to what we're trying to fix here.

As much as I want to approve, I should not to avoid accidental merge of this experimental PR, LOL. Thank you!

bsipocz · 2020-05-05T02:59:20Z

@pllim - then I go ahead and merge the upstream and close this before accidents happen :)

However, somehow locally I still have the asdf failures, even though there is an importskip at the top of the file. But neither you nor CI sees it, I conclude it's a weird local issue.

pllim · 2020-05-05T03:02:46Z

Weird that importorskip is not working for you. I wonder if you have an old version or a totally different asdf sneaking somewhere in your installation... Maybe can follow-up on Slack.

bsipocz added testing skip-changelog-checks Tells bot to skip changlog checks labels Apr 30, 2020

bsipocz added this to the v4.1 milestone Apr 30, 2020

bsipocz added the 🔥 Critical label Apr 30, 2020

bsipocz force-pushed the pytest_remove_5.4_pin branch 2 times, most recently from 888ce11 to 1a016c1 Compare May 4, 2020 19:11

bsipocz mentioned this pull request May 4, 2020

MNT: Make asdf import truly optional in io.misc.asdf #10260

Closed

1 task

DO NOT MERGE TST: testing upstream ci-helpers

71e2e56

bsipocz force-pushed the pytest_remove_5.4_pin branch from 1a016c1 to 71e2e56 Compare May 5, 2020 01:42

pllim self-requested a review May 5, 2020 01:47

bsipocz closed this May 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DO NOT MERGE TST: testing upstream ci-helpers#10237

DO NOT MERGE TST: testing upstream ci-helpers#10237
bsipocz wants to merge 1 commit intoastropy:masterfrom
bsipocz:pytest_remove_5.4_pin

bsipocz commented Apr 30, 2020

Uh oh!

bsipocz commented Apr 30, 2020

Uh oh!

bsipocz commented Apr 30, 2020

Uh oh!

mhvk commented May 3, 2020

Uh oh!

bsipocz commented May 5, 2020

Uh oh!

pllim commented May 5, 2020

Uh oh!

bsipocz commented May 5, 2020

Uh oh!

pllim commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bsipocz commented Apr 30, 2020

Uh oh!

bsipocz commented Apr 30, 2020

Uh oh!

bsipocz commented Apr 30, 2020

Uh oh!

mhvk commented May 3, 2020

Uh oh!

bsipocz commented May 5, 2020

Uh oh!

pllim commented May 5, 2020

Uh oh!

bsipocz commented May 5, 2020

Uh oh!

pllim commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants