Skip to content

EXP: Pin pytest-openfiles in old deps job#10164

Merged
bsipocz merged 2 commits intoastropy:masterfrom
pllim:fix-old-deps
Apr 20, 2020
Merged

EXP: Pin pytest-openfiles in old deps job#10164
bsipocz merged 2 commits intoastropy:masterfrom
pllim:fix-old-deps

Conversation

@pllim
Copy link
Member

@pllim pllim commented Apr 17, 2020

Description

This pull request is to address Travis CI failure related to old dependencies.

Fixes #10160

Note to reviewer: Please also check remote data job on Travis CI that is allowed to fail.

@pllim pllim added this to the v4.0.2 milestone Apr 17, 2020
@pllim pllim added the 🔥 Critical label Apr 17, 2020
@pllim
Copy link
Member Author

pllim commented Apr 17, 2020

Aha, so it is pytest-openfiles! (Looking at you, @astrofrog ! 😉 )

I will do a force push and let the whole suite runs.

ref: https://travis-ci.org/github/astropy/astropy/builds/676400877

@pllim pllim requested a review from bsipocz April 17, 2020 21:38
@bsipocz
Copy link
Member

bsipocz commented Apr 18, 2020

Maybe add a comment that we pin this as otherwise it's causing stalling not because it's a minimum requirement.

@astrofrog
Copy link
Member

I'll investigate on Monday, but please feel free to merge this once ready!

@pllim
Copy link
Member Author

pllim commented Apr 20, 2020

Need an approval to merge.

@bsipocz bsipocz merged commit 2b4cb76 into astropy:master Apr 20, 2020
@bsipocz
Copy link
Member

bsipocz commented Apr 20, 2020

sorry @pllim for the delay

@bsipocz
Copy link
Member

bsipocz commented Apr 28, 2020

I did this version limit manually on the LTS branch as we don't do tox there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: py36-test-oldestdeps failing with timeout exceeded

3 participants