ENH: astropy.io.votable.exceptions.conf.max_warnings#10152
ENH: astropy.io.votable.exceptions.conf.max_warnings#10152pllim merged 1 commit intoastropy:masterfrom
Conversation
tomdonaldson
left a comment
There was a problem hiding this comment.
This looks good to me. Just had one minor question for my own education.
|
|
||
| __all__ = [ | ||
| 'warn_or_raise', 'vo_raise', 'vo_reraise', 'vo_warn', | ||
| 'Conf', 'conf', 'warn_or_raise', 'vo_raise', 'vo_reraise', 'vo_warn', |
There was a problem hiding this comment.
Is the capital C Conf needed here? I didn't notice it being referenced, but I'm probably missing some of the black magic needed for setup.
There was a problem hiding this comment.
I just copy-pasted that part from the __init__.py file. If you feel strongly about it, I can remove it. I think all this affects is the from astropy.io.votable.exceptions import * command and also when Sphinx scrapes the files for API doc.
There was a problem hiding this comment.
Ah, actually, I do need to change the doc a little to make it render.
There was a problem hiding this comment.
I pushed the doc update. Given that the doc doesn't use automodapi for exceptions, this addition only affects star-imports. Are you okay with leaving this in or you want me to take it back out? Please advise, @tomdonaldson . Thanks!
There was a problem hiding this comment.
I'm fine leaving it in since I'm not sure enough that it would never be useful. It's certainly not harmful in any important way.
bf22a6b to
ec32690
Compare
|
Thanks for the review, @tomdonaldson ! |
Description
This pull request is to add a new configuration item to replace hardcoded
MAX_WARNINGSinastropy.io.votable.exceptions.Fixes #7529