Skip to content

0e69c4db introduced asv regression #3232

@mdboom

Description

@mdboom

I'm not saying this an issue to be resolved -- just reporting it FYI.

0e69c4d appears to have introduced a major speed regression in many of the io.ascii benchmarks:

  • AastexFloat
  • AastexInt
  • FixedWidthFloat
  • FixedWidthInt
  • FixedWidthNoHeaderFloat
  • FixedWidthNoHeaderInt
  • FixedWidthString
  • IpacFloat
  • IpacInt
  • IpacString
  • CoreSuite.time_base_splitter
  • CoreSuite.time_continuation_inputter
  • CoreSuite.time_convert_vals

It's a very simple change -- I suspect most of the time is just from adding a __getitem__ vs. not having one. I'm not sure if there's a way to fix the bug in another way, or if it matters. Like I say, just reporting it at this point.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions