Description
Prior to #11204, the physical_type attribute of units was a string with the name of the unit. #11204 transformed the physical_type attribute into instances of the new PhysicalType class. #11204 did preserve much of the behavior of the string API (such as having == work between PhysicalType instances and strings), but there were a few ways that it did not. A few of these ways are being discussed in #11204 starting with this comment. A lot of this could probably be done with this suggestion from @mhvk.
Suggestions on specific string behaviors to include and test for would be appreciated!
Description
Prior to #11204, the
physical_typeattribute of units was a string with the name of the unit. #11204 transformed thephysical_typeattribute into instances of the newPhysicalTypeclass. #11204 did preserve much of the behavior of the string API (such as having==work betweenPhysicalTypeinstances and strings), but there were a few ways that it did not. A few of these ways are being discussed in #11204 starting with this comment. A lot of this could probably be done with this suggestion from @mhvk.Suggestions on specific string behaviors to include and test for would be appreciated!