Skip to content

remove astropy_init#263

Merged
braingram merged 4 commits into
astropy:mainfrom
braingram:no_more_astropy_init
Mar 10, 2025
Merged

remove astropy_init#263
braingram merged 4 commits into
astropy:mainfrom
braingram:no_more_astropy_init

Conversation

@braingram

@braingram braingram commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

This removes _astropy_init.py. It is leftover from a no longer maintained project template:
https://github.com/astropy/package-template
and contains:

  • code to provide asdf_astropy.__version__ (moved to __init__.py in this PR)
  • code to (attempt to use) the astropy TestRunner vai asdf_astropy.test()

The TestRunner will soon be deprecated and attempting to use it on main fails with:

PytestAssertRewriteWarning: Module already imported so cannot be rewritten: asdf

Our documentation already describes ways to run the tests (none of which use asdf_astropy.test):

Testing

Since asdf_astropy.test is not working and not documented this PR removes it.

Closes #262

@codecov

codecov Bot commented Feb 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (72497e9) to head (1ccf841).
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          62       62           
  Lines        2209     2209           
=======================================
  Hits         2198     2198           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review February 14, 2025 22:15

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor comment.

Comment thread asdf_astropy/__init__.py Outdated
braingram and others added 4 commits March 10, 2025 14:22
@braingram braingram force-pushed the no_more_astropy_init branch from ad61e81 to 1ccf841 Compare March 10, 2025 18:22
@braingram braingram merged commit ac88fb7 into astropy:main Mar 10, 2025
@braingram braingram deleted the no_more_astropy_init branch March 10, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notice: You are using astropy TestRunner that will be deprecated

2 participants