Skip to content

Improve misc Rendering, Analyze Command, OrbiterOperator#127

Merged
fritz-astronomer merged 18 commits intomainfrom
misc
Jan 16, 2026
Merged

Improve misc Rendering, Analyze Command, OrbiterOperator#127
fritz-astronomer merged 18 commits intomainfrom
misc

Conversation

@fritz-astronomer
Copy link
Contributor

@fritz-astronomer fritz-astronomer commented Jan 16, 2026

closes #126

  • fix: import datetime not from datetime
  • feat: add task_type fn to cannot_map_rule
  • feat(objects): add doc_md to operator
  • feat(objects): add EmptyOp if Dag/TaskGroup are empty (to prevent py error)

@fritz-astronomer fritz-astronomer self-assigned this Jan 16, 2026
@fritz-astronomer fritz-astronomer added the bug Something isn't working label Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the rendering of import statements to correctly distinguish between import and from ... import syntax in the requirement module.

Changes:

  • Added conditional logic to properly handle module-based imports versus direct imports
  • Ensured import datetime is rendered correctly instead of from datetime

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.41%. Comparing base (b3ee237) to head (18bc04f).
⚠️ Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
orbiter/assets/operators/unmapped_src.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   78.92%   82.41%   +3.48%     
==========================================
  Files          35       51      +16     
  Lines        1362     2019     +657     
==========================================
+ Hits         1075     1664     +589     
- Misses        287      355      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fritz-astronomer fritz-astronomer changed the title Improve Requirement Rendering Improve misc Rendering, Analyze Command, OrbiterOperator Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fritz-astronomer fritz-astronomer merged commit bb57d4d into main Jan 16, 2026
8 checks passed
@fritz-astronomer fritz-astronomer deleted the misc branch January 16, 2026 22:40
@fritz-astronomer fritz-astronomer linked an issue Jan 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty names for OrbiterRequirement doesn't render correctly Empty DAGs don't render correctly

3 participants