Find ruff more effectively for linting/formatting step#124
Find ruff more effectively for linting/formatting step#124fritz-astronomer merged 5 commits intomainfrom
ruff more effectively for linting/formatting step#124Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 78.92% 82.27% +3.35%
==========================================
Files 35 51 +16
Lines 1362 2009 +647
==========================================
+ Hits 1075 1653 +578
- Misses 287 356 +69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of finding the ruff executable for linting and formatting operations by utilizing ruff's own find_ruff_bin function when available, with a fallback to shutil.which('ruff').
Changes:
- Updated
run()function signature to accept both string and list commands - Added logic to locate ruff executable using ruff's internal
find_ruff_binfunction with fallback - Updated ruff command invocations to use the dynamically found ruff path
- Bumped version to 1.10.3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| orbiter/main.py | Added ruff executable discovery logic and updated command calls to use found path |
| orbiter/init.py | Version bump to reflect the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
utilizes https://github.com/astral-sh/ruff/blob/main/python/ruff/__main__.py#L8
Falls back to
shutil.which('ruff')