Skip to content

Remove Pydantic Version Ceiling & Remove Pydantic from TranslationRuleset+Ruleset#123

Merged
fritz-astronomer merged 7 commits intomainfrom
pydantic
Jan 12, 2026
Merged

Remove Pydantic Version Ceiling & Remove Pydantic from TranslationRuleset+Ruleset#123
fritz-astronomer merged 7 commits intomainfrom
pydantic

Conversation

@fritz-astronomer
Copy link
Contributor

@fritz-astronomer fritz-astronomer commented Jan 12, 2026

  • chore: rm pydantic version ceiling to match af
  • fix(rulesets): remove pydantic from Ruleset, TranslationRuleset to resolve errors
  • fix(rulesets): rm ABC from TranslationRuleset

@fritz-astronomer fritz-astronomer self-assigned this Jan 12, 2026

This comment was marked as outdated.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (b3ee237) to head (6aab6e2).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   78.92%   82.73%   +3.80%     
==========================================
  Files          35       51      +16     
  Lines        1362     1998     +636     
==========================================
+ Hits         1075     1653     +578     
- Misses        287      345      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fritz-astronomer and others added 5 commits January 12, 2026 16:39
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: fritz-astronomer <80706212+fritz-astronomer@users.noreply.github.com>

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fritz-astronomer fritz-astronomer changed the title Remove Pydantic Version Ceiling to correctly install AF3 in dev Remove Pydantic Version Ceiling & remove Pydantic from TranslationRuleset+Ruleset Jan 12, 2026
@fritz-astronomer fritz-astronomer changed the title Remove Pydantic Version Ceiling & remove Pydantic from TranslationRuleset+Ruleset Remove Pydantic Version Ceiling & Remove Pydantic from TranslationRuleset+Ruleset Jan 12, 2026
@fritz-astronomer fritz-astronomer merged commit 123e487 into main Jan 12, 2026
8 checks passed
@fritz-astronomer fritz-astronomer deleted the pydantic branch January 12, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants